Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Add error handling to DivideScalar action

Description

The DivideScalar action in analysis_tools with raise a ValueError if the denominator is zero. There are cases where we might want to supply a fallback value (e.g. 0 or nan) rather than raising an error.

Issue Matrix

hide

Activity

Show:

Erfan Nourbakhsh July 17, 2024 at 5:48 AM
Edited

Erfan Nourbakhsh July 16, 2024 at 3:55 AM
Edited

Fred Moolekamp July 15, 2024 at 8:12 PM

I’m wondering if the use of NaN vs infinity might need to be brought to the RFC level. In the meantime I'm ok with the change and I think that it's ok to merge this, once the comments in the PR are addressed and Jenkins is run. Once the RFC has completed the value can always be changed.

Erfan Nourbakhsh July 13, 2024 at 4:28 AM
Edited

This has caused problems for me while working on . There were 22 cases with ValueError("Denominator is zero!"). I might need to work on this ticket along with DM-44318.

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Labels

Reviewers

Fred Moolekamp

Story Points

RubinTeam

Data Release Production

Components

Parent

Checklist

Created March 20, 2024 at 6:36 PM
Updated December 23, 2024 at 11:04 PM
Resolved July 17, 2024 at 11:52 PM