Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Support bind parameters for dataset queries using IN

Description

Many of our tutorials use "IN" in query strings for queryDatasets WHERE clauses and we also encourage use of the bind parameters. Unfortunately IN does not work with bind. Consider adding support for IN such that the bind parameter value can be given as a python list.

Checklist

Lucidchart Diagrams

Issue Matrix

hide

Activity

Show:
Tim Jenness
October 25, 2022 at 10:01 PM

this is another ticket that will help simplify the tutorials once it gets into the default weekly. You will no longer need to make a big query string for the where clause.

Andy Salnikov
October 25, 2022 at 9:49 PM

Thanks for review and suggestions. I have added collections.abc.Set to the mix. Will merge after Jenkins finishes last check.

Jim Bosch
October 25, 2022 at 6:17 PM

Looks good - only line comments are doc grammar adjustments.

I do wonder whether it's worth trying to support collections.abc.Set or at least set and frozenset, as well as list and tuple, but I don't think it's a big deal either way.

As a heads-up, this is all going to be refactored significantly when I rebase https://rubinobs.atlassian.net/browse/DM-31725#icft=DM-31725 on it, but with the nice tests you've added it shouldn't be hard to keep the behavior the same.

Andy Salnikov
October 21, 2022 at 6:21 PM

, this should be ready for review. It's a bit messy and I hope it does not break CheckVisitor. OTOH I extended unit tests and documentation, and Jenkins seems to be OK with everything.

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Labels

Reviewers

Jim Bosch

Story Points

RubinTeam

Components

Checklist

Created September 22, 2022 at 4:15 PM
Updated October 27, 2022 at 9:09 PM
Resolved October 26, 2022 at 1:38 AM