Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

queryDataIds fails when a dataset existence constraint involves a dataset type with no dimensions

Description

When given a dataset type with no dimensions, queryDataIds generates a query with subqueries of the form:

SELECT FROM dataset_tags_00000000 WHERE dataset_tags_00000000.dataset_type_id = ? AND dataset_tags_00000000.collection_id = ?

(note lack of columns in the select clause).

Checklist

Issue Matrix

hide

Lucidchart Diagrams

Activity

Jim Bosch May 16, 2022 at 11:38 PM

Story points updated.

Yusra AlSayyad May 16, 2022 at 11:26 PM

story point estimate?

Andy Salnikov April 10, 2022 at 11:32 PM

Looks good, couple of minor comments.

Jim Bosch April 9, 2022 at 3:29 AM

, I'm putting this back into review one more time, because your last comment led me to uncover another bug introduced by the refactor, again with a nontrivial fix. Once again, it's the last three commits that are new.

Clearly a cautionary table about "cleaning up messy code" when at least some of the "mess" is actually hard-won edge-case bug fixes, but I do still think the structure is much better overall.

Andy Salnikov April 7, 2022 at 4:11 PM

Looks good.

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Labels

Reviewers

Andy Salnikov

Story Points

RubinTeam

Data Release Production

Components

Parent

Checklist

Created March 30, 2022 at 5:08 PM
Updated May 19, 2022 at 4:58 PM
Resolved April 11, 2022 at 7:15 PM