Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Incompatibility with NumPy 1.13

Description

Per this report on CLO, our test suite fails when run against NumPy 1.13.0:

File "tests/testSimpleTable.py", line 346, in testExtract self.assertFloatsEqual(d["a_b_c2"], catalog.get("a_b_c2")[idx]) File "/home/mnewsome/envs/lsst_maf/lsst/Linux64/utils/13.0/python/lsst/utils/tests.py", line 652, in assertFloatsEqual return assertFloatsAlmostEqual(testCase, lhs, rhs, rtol=0, atol=0, **kwargs) File "/home/mnewsome/envs/lsst_maf/lsst/Linux64/utils/13.0/python/lsst/utils/tests.py", line 568, in assertFloatsAlmostEqual diff = lhs - rhs TypeError: numpy boolean subtract, the - operator, is deprecated, use the bitwise_xor, the ^ operator, or the logical_xor function instead.

This has been promoted from a DeprecationWarning to a TypeError as of NumPy 1.13.0, which was recently released.

Checklist

Lucidchart Diagrams

Issue Matrix

hide

Activity

Show:
Pim Schellart [X]
June 24, 2017 at 8:04 AM

Merged after implementing review comments.

Tim Jenness
June 13, 2017 at 11:59 PM

I think DeprecationWarnings do get printed out when tests are run but nothing is filtering the output and making it obvious.

John Parejko
June 13, 2017 at 4:22 PM
(edited)

"a_b_c2" is a "Flag" Field, which we emphatically should not be testing via assertFloatsEqual. Same for Field "a_d1", which is an int.

We should also run with DeprecationWarning active, as this isn't going to be the only line with this problem (per the above Community post).

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Labels

Reviewers

John Parejko

Story Points

RubinTeam

Components

Sprint

None

Parent

Checklist

Created June 13, 2017 at 4:14 PM
Updated August 29, 2017 at 8:31 AM
Resolved June 24, 2017 at 8:04 AM