Remove undesirable defensiveness in Registry.findDatasets and fix query truncation bug

Description

The reimplementation of Registry.findDatasets on https://rubinobs.atlassian.net/browse/DM-31725#icft=DM-31725 was unintentionally more defensive about silently skipping collections than the previous implementation, and this broke the usual workaround for getting "camera" datasets without a timespan.

In addition, the way queries are generated now makes us more susceptible to problems due to PostgreSQL's truncation of symbols longer than 64 chars.

See https://lsstc.slack.com/archives/C01FBUGM2CV/p1675186972639619 (and ensuing conversation) and https://lsstc.slack.com/archives/C01FBUGM2CV/p1675792821880709 for details.

Linked work items

relates to

DM-31725

Rewrite butler registry.queries subpackage

Checklist

Lucidchart Diagrams

Issue Matrix

hide

Activity

Show:

Andy Salnikov

February 8, 2023 at 5:35 AM

Looks good to me.

Jim Bosch

February 7, 2023 at 10:09 PM

@Andy Salnikov, I've got two fixes for problems introduced on https://rubinobs.atlassian.net/browse/DM-31725#icft=DM-31725 here, as well as some MyPy fixes. I've only just started Jenkins and there are PyPI version issues blocking the GitHub CI at present (see https://lsstc.slack.com/archives/C2JP6PQLC/p1675807405333209?thread_ts=1675807249.647469&cid=C2JP6PQLC), but I figured we could get the review started and hope those sort themselves out.

PRs are:

Resize work item view side panel

Done

Pinned fields

Click on the next to a field label to start pinning.

Details

Assignee

Jim Bosch

Reporter

Jim Bosch

Labels

gen3-middleware

Reviewers

Andy Salnikov

Story Points

RubinTeam

Data Release Production

Components

daf_butler

Parent

DM-32168 Emergent Work for DRP in S23A

Priority

Undefined

Checklist

Created February 6, 2023 at 4:35 PM

Updated February 9, 2023 at 5:04 AM

Resolved February 8, 2023 at 3:52 PM