Test and Implement Default Parameters for Jointcal Outlier Rejection
Description
Attachments
relates to
Checklist
Lucidchart Diagrams
Issue Matrix
hideActivity
Clare Saunders July 27, 2021 at 10:59 PM
Lauren MacArthur July 27, 2021 at 9:10 PM
The updates LGTM.
Out of an (over?!)abundance of paranoia, I always tend to kick off a Jenkins, even for minor changes/time gone by, just to be sure
Clare Saunders July 27, 2021 at 8:48 PM
Great. I implemented your comments on the jointcal
pull request, so if that looks okay to you I'll go ahead and merge this.
Lauren MacArthur July 27, 2021 at 8:30 PM
Sounds and looks good to me. Thanks for the update!
Clare Saunders July 27, 2021 at 7:57 PM
, and I discussed your comments on the differences between the jointcal results with and without the outlier tolerance behavior. We decided that the differences at the edge of the focal plane are driven by observations that we want to be keeping, not rejecting, in order to constrain the behavior of the model at the edges. The ON results are in general somewhat closer to the reference catalog, so it looks like the differences are desired behavior and are improving the final results.
The difference in the number of outliers seems to be okay. The total number of measured stars is O(200k), so the differences you saw come to a few percent and would correspond to a couple stars per visit per ccd (or more likely several stars per edge ccd and fewer in the center ccds).
I decided I needed to rerun the post-jointcal steps to resolve the issues with the colorAnalysis
plots (which is why this response has been delayed). The color plots in the comment above have been updated, as were the full results at [lsst.ncsa.illinois.edu/~csaunder/DM-30534|lsst.ncsa.illinois.edu/~csaunder/DM-30534]. The change in the standard deviation between OFF and ON seems reasonable to me, going for example from 10.59 to 10.64 for tract 9615 and from 11.34 to 11.51 for tract 9697. I am still running tract 9813 and will add those results when it finishes.
added an option to stop outlier rejection early. We need to investigate what value is appropriate for the new
astrometryRelativeOutlierTolerance
parameter and to set that value as the default for processing HSC data.Results
The default
jointcal
configuration performs chi2 minimization and outlier rejection steps in which iterations of outlier rejection are continued until no more outlier measurements are found. Whenjointcal
is run on hundreds of visits, this means that runtime can stretch to multiple weeks. TheastrometryOutlierRelativeTolerance
parameter adds the option to stop iterations of outlier rejection at the point when rejecting additional outliers has a minimal effect on the chi2. Iterations stop when the fractional change in chi2 is below the astrometryOutlierRelativeTolerance parameter.Initial testing on sets of 10, 100, and 378 visits in Tract 9813 indicated that setting the parameter to 0.002 provided a good compromise between speeding up the runtime while having a minimal effect on the final model. For very large datasets, runtime should be cut to a couple of days in lieu of a couple of weeks. Plots showing these results are attached to . Running with this value was subsequently tested on RC2.
Running the
validateDRP
andpipe_analysis
scripts on both these results (identified in plots as “optionON”) and the results of runningjointcal
in the default configuration (“optionOFF”) shows that stopping outlier rejection iterations earlier has a minimal effect on the final astrometric model. For the System Science Requirements metrics AM1 and AM2, turning on the optional parameter changes the metric values by less than 0.1 marcsec in general, or about 2%, with a few cases where the metrics are up to 0.2 marcsec higher. The AF1 and AF2 metrics are similarly only slightly changed, and in many cases are better with the optional parameter turned on. A summary of the changes in the AMx and AFx results is shown in the attached plotvalDRP_synopsis.png
, and the full diagnostic plots are shown in the comments below.Similarly, comparison of the diagnostics output by
visitAnalysis.py
shows that the results from thejointcal
runs with the parameter turned on are equivalent, or in some cases better, than the results from the default configuration. This is particularly true in the cases, many inHSC-Y
, where the mean and standard deviation are high in the default configuration. The attached plotvisitAna_synopsis.png
shows the change in mean and standard deviation for a sample of twenty visits. The {{plot-vNNNN-matches_{ra/dec/raCosDec}-sky-stars.png}} plots and {{plot-vNNNNN-matches_{ra/dec/raCosDec}
-psfMagHist.png}} for a selection of visits are in the comments below.
The full outputs of
matchedVisitMetrics.py
,visitAnalysis.py
, andcolorAnalysis.py
for optionON and optionOFF are available at lsst.ncsa.illinois.edu/~csaunder/DM-30534/. The output ofcompareVisitAnalysis.py
is also available in the optionOFFvisitAnalysis
directories.The conclusion of these tests is that running
jointcal
with the parameterastrometryOutlierRelativeTolerance
turned on and set to a value of 0.002 for HSC will have a negligible impact on the final output of the pipeline.